Fix: Bug related shielded action for transfer#734
Open
pnam1609 wants to merge 1 commit intonamada-net:mainfrom
Open
Fix: Bug related shielded action for transfer#734pnam1609 wants to merge 1 commit intonamada-net:mainfrom
pnam1609 wants to merge 1 commit intonamada-net:mainfrom
Conversation
Author
|
I tried latest code and i can't query shielded balance. So my PR used a old commit to base it on. That reason why my code have a lot conflict file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issue:
Bug 1: Wrong chain id passing for shielded IBC transfer ( only IBC shielded )
Bug 2: Private key is not passing into shielded action ( both IBC shielded and internal shielded transfer )
Bug 3: Public key is missing in txArgs when execute shielded transfer ( both ibc shielded and internal shielded transfer )
Bug 4: disposable_signing_key should be false when using shielded transfer ( only internal shielded transfer )